fix(gui): Smoothening startup Part I #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosNihelton
force-pushed
the
smooth-startup-p1
branch
from
75e8e20 to
e8f64e4
Compare
By means of the Filesystem events API. That ensures we don't launch the agent more than once, until startup timeouts.
What happens if we start watching for the addr file but it never shows up? The answer is: our outer timeout catches us. So the stream would emit 'AgentState.unreachable' and we are done.
That was previously reduced. Speeding up the agent seems to have broken the test.
CarlosNihelton
force-pushed
the
smooth-startup-p1
branch
from
e8f64e4 to
94b21f7
Compare
EduardGomezEscandell
approved these changes
Oct 30, 2023
CarlosNihelton
added a commit
that referenced
this pull request
Oct 31, 2023
This completes UDENG-1595, by building on top of #355 with the visible aspects of the change. Now the GUI automatically attempts to delete the `addr` file and restart the agent. Here's how it looks like when a port file is found but the agent is not running, thus not responsive. https://github.com/canonical/ubuntu-pro-for-windows/assets/11138291/870b32e3-17f6-4890-8376-0473b0cb5b23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this renders best if split in two pull requests: one dealing with the lower level code (this one) and another dealing with the visible parts of the user interface. This way it's easier for reviewers and also unblocks @EduardGomezEscandell's work more quickly.
So in this PR we reduce the duration of a timeout in case no changes in the startup state machine happen and we watch for the creation of the
addrfile. The watch only happens in the code path that causes the GUI to start the agent. For the watch operation to happen we need the directory to exist, so I added a precaution step to create it. It doesn't fail in case the directory already exists. It's important that we start watching the directory before launching the agent, otherwise race conditions could happen. Thus we start watching first, then launch the agent, and finally wait for the watching operation to complete (which may have completed by the time we start waiting, which is not a problem at all). This prevents the GUI from spawning more than one agent process.The last commit increases the timeout of one specific end-to-end test because I could see it failing before in CI killing the context, although I could never reproduce it locally not even with VMs.